gitweb: esc_html_hl_regions(): Don't create empty <span> elements

[Gitweb] / gitweb.perl

diff --git a/gitweb.perl b/gitweb.perl
index 144b9684ab71e5461d8641e11ffafec7d5c106d3303387ee865a983e26cc0973..91663a4d044681f218a5bbbbff8eba71f6ce3abbc408a4cfef6f7291d72c55da 100755 (executable)
--- a/gitweb.perl
+++ b/gitweb.perl
@@ -1739,12 +1739,18 @@ sub esc_html_hl_regions {
        my $pos = 0;
 
        for my $s (@sel) {
        my $pos = 0;
 
        for my $s (@sel) {

-               $out .= esc_html(substr($str, $pos, $s->[0] - $pos))
-                       if ($s->[0] - $pos > 0);
-               $out .= $cgi->span({-class => $css_class},
-                                  esc_html(substr($str, $s->[0], $s->[1] - $s->[0])));
+               my ($begin, $end) = @$s;

 
 

-               $pos = $s->[1];
+               # Don't create empty <span> elements.
+               next if $end <= $begin;
+
+               my $escaped = esc_html(substr($str, $begin, $end - $begin));
+
+               $out .= esc_html(substr($str, $pos, $begin - $pos))
+                       if ($begin - $pos > 0);
+               $out .= $cgi->span({-class => $css_class}, $escaped);
+
+               $pos = $end;

        }
        $out .= esc_html(substr($str, $pos))
                if ($pos < length($str));
        }
        $out .= esc_html(substr($str, $pos))
                if ($pos < length($str));