gitweb: Put all per-connection code in run() subroutine

[Gitweb] / gitweb.js

diff --git a/gitweb.js b/gitweb.js
index 1b0d1f98bc41e339031faf94eade3e778b38d6b5a74bb11cb0b136a9ab801300..1f77d37887e350d2dba636fed0fd5a45489cca78d0c572be8ce397314eb3277e 100644 (file)
--- a/gitweb.js
+++ b/gitweb.js
@@ -64,19 +64,19 @@ function fixLinks() {
 
 /**
  * pad number N with nonbreakable spaces on the left, to WIDTH characters
 
 /**
  * pad number N with nonbreakable spaces on the left, to WIDTH characters

- * example: padLeftStr(12, 3, ' ') == ' 12'
- *          (' ' is nonbreakable space)
+ * example: padLeftStr(12, 3, '\u00A0') == '\u00A012'
+ *          ('\u00A0' is nonbreakable space)

  *
  * @param {Number|String} input: number to pad
  * @param {Number} width: visible width of output
  *
  * @param {Number|String} input: number to pad
  * @param {Number} width: visible width of output

- * @param {String} str: string to prefix to string, e.g. ' '
+ * @param {String} str: string to prefix to string, e.g. '\u00A0'

  * @returns {String} INPUT prefixed with (WIDTH - INPUT.length) x STR
  */
 function padLeftStr(input, width, str) {
        var prefix = '';
 
        width -= input.toString().length;
  * @returns {String} INPUT prefixed with (WIDTH - INPUT.length) x STR
  */
 function padLeftStr(input, width, str) {
        var prefix = '';
 
        width -= input.toString().length;

-       while (width > 1) {
+       while (width > 0) {

                prefix += str;
                width--;
        }
                prefix += str;
                width--;
        }


@@ -192,7 +192,7 @@ function updateProgressInfo() {
 
        if (div_progress_info) {
                div_progress_info.firstChild.data  = blamedLines + ' / ' + totalLines +
 
        if (div_progress_info) {
                div_progress_info.firstChild.data  = blamedLines + ' / ' + totalLines +

-                       ' (' + padLeftStr(percentage, 3, ' ') + '%)';
+                       ' (' + padLeftStr(percentage, 3, '\u00A0') + '%)';

        }
 
        if (div_progress_bar) {
        }
 
        if (div_progress_bar) {


@@ -562,7 +562,12 @@ function handleLine(commit, group) {
                        td_sha1.rowSpan = group.numlines;
 
                        a_sha1.href = projectUrl + 'a=commit;h=' + commit.sha1;
                        td_sha1.rowSpan = group.numlines;
 
                        a_sha1.href = projectUrl + 'a=commit;h=' + commit.sha1;

-                       a_sha1.firstChild.data = commit.sha1.substr(0, 8);
+                       if (a_sha1.firstChild) {
+                               a_sha1.firstChild.data = commit.sha1.substr(0, 8);
+                       } else {
+                               a_sha1.appendChild(
+                                       document.createTextNode(commit.sha1.substr(0, 8)));
+                       }

                        if (group.numlines >= 2) {
                                var fragment = document.createDocumentFragment();
                                var br   = document.createElement("br");
                        if (group.numlines >= 2) {
                                var fragment = document.createDocumentFragment();
                                var br   = document.createElement("br");


@@ -774,7 +779,12 @@ function handleResponse() {
        }
 
        // the server returned error
        }
 
        // the server returned error

-       if (xhr.readyState === 3 && xhr.status !== 200) {
+       // try ... catch block is to work around bug in IE8
+       try {
+               if (xhr.readyState === 3 && xhr.status !== 200) {
+                       return;
+               }
+       } catch (e) {

                return;
        }
        if (xhr.readyState === 4 && xhr.status !== 200) {
                return;
        }
        if (xhr.readyState === 4 && xhr.status !== 200) {