gitweb.js: Harden setting blamed commit info in incremental blame

[Gitweb] / gitweb.js

diff --git a/gitweb.js b/gitweb.js
index d1b64b2aa2b83e1ef875c35bdef23796021fb3398c33e2c07680bd9389be8bb9..ff2d53365b02fd70522a8fcef202dbda902aeb09b31a5da592fab457167e28f4 100644 (file)
--- a/gitweb.js
+++ b/gitweb.js
@@ -562,12 +562,20 @@ function handleLine(commit, group) {
                        td_sha1.rowSpan = group.numlines;
 
                        a_sha1.href = projectUrl + 'a=commit;h=' + commit.sha1;
                        td_sha1.rowSpan = group.numlines;
 
                        a_sha1.href = projectUrl + 'a=commit;h=' + commit.sha1;

-                       a_sha1.firstChild.data = commit.sha1.substr(0, 8);
+                       if (a_sha1.firstChild) {
+                               a_sha1.firstChild.data = commit.sha1.substr(0, 8);
+                       } else {
+                               a_sha1.appendChild(
+                                       document.createTextNode(commit.sha1.substr(0, 8)));
+                       }

                        if (group.numlines >= 2) {
                                var fragment = document.createDocumentFragment();
                                var br   = document.createElement("br");
                        if (group.numlines >= 2) {
                                var fragment = document.createDocumentFragment();
                                var br   = document.createElement("br");

-                               var text = document.createTextNode(
-                                       commit.author.match(/\b([A-Z])\B/g).join(''));
+                               var match = commit.author.match(/\b([A-Z])\B/g);
+                               if (match) {
+                                       var text = document.createTextNode(
+                                                       match.join(''));
+                               }

                                if (br && text) {
                                        var elem = fragment || td_sha1;
                                        elem.appendChild(br);
                                if (br && text) {
                                        var elem = fragment || td_sha1;
                                        elem.appendChild(br);