]> Lady’s Gitweb - Gitweb/commit
gitweb: Fix and simplify pickaxe search
authorJakub Narebski <redacted>
Wed, 5 Mar 2008 08:31:55 +0000 (09:31 +0100)
committerLady <redacted>
Mon, 6 Apr 2026 04:07:12 +0000 (00:07 -0400)
commit3fc94f88cca1df1e9221a3d39c3edaa38ac20dc417cbf67c6d5efee6f31c3abf
tree982d83768d1e28eb5e850ed3ec63227617e79b8c5a4ff63a86106103835501bd
parent66597c4f8d1d454bbd9c5fd754b7d481064543176c7bef3aaf078ed531ce8922
gitweb: Fix and simplify pickaxe search

Instead of using "git-rev-list | git-diff-tree" pipeline for pickaxe
search, use git-log with appropriate options.  Besides reducing number
of forks by one, this allows to use list form of open, which in turn
allow to not worry about quoting arguments and to avoid forking shell.

The options to git-log were chosen to reduce required changes in
pickaxe git command output parsing; gitweb still parses returned
commits one by one.

Parsing "pickaxe" output is simplified: git_search now reuses
parse_difftree_raw_line and writes affected files as they arrive using
the fact that commit name goes always before [raw] diff.

While at it long bug of pickaxe search was fixed, namely that the last
commit found by pickaxe search was never shown.

Signed-off-by: Jakub Narebski <redacted>
Signed-off-by: Junio C Hamano <redacted>
gitweb.perl
This page took 0.268811 seconds and 4 git commands to generate.