]> Lady’s Gitweb - Gitweb/commit
gitweb: Check that $site_header etc. are defined before using them
authorJohn 'Warthog9' Hawley <redacted>
Sat, 30 Jan 2010 22:30:41 +0000 (23:30 +0100)
committerLady <redacted>
Mon, 6 Apr 2026 04:50:39 +0000 (00:50 -0400)
commitfc87038c3e043a49ddf9fdf04e40c8fcf1095e0b97a4ba8bb3356e9da6c63660
tree86ad199eec2a52d638e93a190a5baf89354ea44ffb4d1f9602b3b0426e566e6e
parent88936eea43e06fbf7ca689bfba0cf18e840e3ce35c0ed399e072fe9f0edbe4d0
gitweb: Check that $site_header etc. are defined before using them

If one of $site_header, $site_footer or $home_text is not defined, you
get extraneous errors in the web logs, for example (line wrapped for
better readibility):

 [Wed Jan 13 16:55:42 2010] [error] [client ::1] [Wed Jan 13 16:55:42 2010]
 gitweb.cgi: Use of uninitialized value $site_header in -f at
 /var/www/gitweb/gitweb.cgi line 3287., referer: http://git/gitweb.cgi

This ensures that those variables are defined before trying to use it.

Note that such error can happen only because of an error in gitweb
config file; building gitweb.cgi can make mentioned variables holding
empty string (it is even the default), but they are still defined.

Signed-off-by: John 'Warthog9' Hawley <redacted>
Signed-off-by: Jakub Narebski <redacted>
Signed-off-by: Junio C Hamano <redacted>
gitweb.perl
This page took 0.182771 seconds and 4 git commands to generate.