gitweb: Check if requested object exists

Try to avoid "Use of uninitialized value ..." errors caused by bad
revision, incorrect filename, wrong object id, bad file etc. (wrong
value of 'h', 'hb', 'f', etc. parameters). This avoids polluting web
server errors log.

Correct git_get_hash_by_path and parse_commit_text (and, in turn,
parse_commit) to return undef if object does not exist.  Check in
git_tag if requested tag exists.

Signed-off-by: Jakub Narebski <redacted>
Signed-off-by: Junio C Hamano <redacted>

diff --git a/gitweb.perl b/gitweb.perl
index e4c20cca00ae4ff6d9a190ef0b0c348ca8c5ae35bff4f2f795d7505182169415..d2b92f57146beda088f036086f736c32a2a4bb13f29cca5328213de4c9837c95 100755 (executable)
--- a/gitweb.perl
+++ b/gitweb.perl
@@ -1061,6 +1061,11 @@ sub git_get_hash_by_path {
        my $line = <$fd>;
        close $fd or return undef;
 
        my $line = <$fd>;
        close $fd or return undef;
 

+       if (!defined $line) {
+               # there is no tree or hash given by $path at $base
+               return undef;
+       }
+

        #'100644 blob 0fa3f3a66fb6a137f6ec2c19351ed4d807070ffa  panic.c'
        $line =~ m/^([0-9]+) (.+) ([0-9a-fA-F]{40})\t/;
        if (defined $type && $type ne $2) {
        #'100644 blob 0fa3f3a66fb6a137f6ec2c19351ed4d807070ffa  panic.c'
        $line =~ m/^([0-9]+) (.+) ([0-9a-fA-F]{40})\t/;
        if (defined $type && $type ne $2) {


@@ -1377,8 +1382,12 @@ sub parse_commit_text {
 
        pop @commit_lines; # Remove '\0'
 
 
        pop @commit_lines; # Remove '\0'
 

+       if (! @commit_lines) {
+               return;
+       }
+

        my $header = shift @commit_lines;
        my $header = shift @commit_lines;

-       if (!($header =~ m/^[0-9a-fA-F]{40}/)) {
+       if ($header !~ m/^[0-9a-fA-F]{40}/) {

                return;
        }
        ($co{'id'}, my @parents) = split ' ', $header;
                return;
        }
        ($co{'id'}, my @parents) = split ' ', $header;


@@ -3410,6 +3419,11 @@ sub git_tag {
        git_header_html();
        git_print_page_nav('','', $head,undef,$head);
        my %tag = parse_tag($hash);
        git_header_html();
        git_print_page_nav('','', $head,undef,$head);
        my %tag = parse_tag($hash);

+
+       if (! %tag) {
+               die_error(undef, "Unknown tag object");
+       }
+

        git_print_header_div('commit', esc_html($tag{'name'}), $hash);
        print "<div class=\"title_text\">\n" .
              "<table cellspacing=\"0\">\n" .
        git_print_header_div('commit', esc_html($tag{'name'}), $hash);
        print "<div class=\"title_text\">\n" .
              "<table cellspacing=\"0\">\n" .