From: Andrew Keller <redacted>
Date: Mon, 17 Feb 2014 14:25:13 +0000 (-0500)
Subject: gitweb: Avoid overflowing page body frame with large images
X-Git-Url: https://git.ladys.computer/Gitweb/commitdiff_plain/1e1514777ab915e30626229f8fd99c44fba2cb1e2a98991a51a54f63dbfa3e7a?ds=sidebyside;hp=24eefea5ad720351fb757031814e2cce219725a5fa9b7e02c88eb45bd0219e1b

gitweb: Avoid overflowing page body frame with large images

When displaying a blob in gitweb, if it's an image, specify constraints for
maximum display width and height to prevent the image from overflowing the
frame of the enclosing page_body div.

This change assumes that it is more desirable to see the whole image without
scrolling (new behavior) than it is to see every pixel without zooming
(previous behavior).

Signed-off-by: Andrew Keller <redacted>
Signed-off-by: Junio C Hamano <redacted>
---

diff --git a/gitweb.perl b/gitweb.perl
index 1c8196b..39f6641 100755
--- a/gitweb.perl
+++ b/gitweb.perl
@@ -7095,7 +7095,7 @@ sub git_blob {
 	git_print_page_path($file_name, "blob", $hash_base);
 	print "<div class=\"page_body\">\n";
 	if ($mimetype =~ m!^image/!) {
-		print qq!<img type="!.esc_attr($mimetype).qq!"!;
+		print qq!<img class="blob" type="!.esc_attr($mimetype).qq!"!;
 		if ($file_name) {
 			print qq! alt="!.esc_attr($file_name).qq!" title="!.esc_attr($file_name).qq!"!;
 		}
diff --git a/static/gitweb.css b/static/gitweb.css
index 46449f1..15792fe 100644
--- a/static/gitweb.css
+++ b/static/gitweb.css
@@ -32,6 +32,11 @@ img.avatar {
 	vertical-align: middle;
 }
 
+img.blob {
+	max-height: 100%;
+	max-width: 100%;
+}
+
 a.list img.avatar {
 	border-style: none;
 }