From: Jakub Narebski <redacted>
Date: Sat, 18 Nov 2006 22:35:38 +0000 (+0100)
Subject: gitweb: Protect against possible warning in git_commitdiff
X-Git-Url: https://git.ladys.computer/Gitweb/commitdiff_plain/20e0ba5af98bb88e94fc0a714baf9e288e7a3bf20f7d3c0352e3b8b6d895da48

gitweb: Protect against possible warning in git_commitdiff

We may read an undef from <$fd> and unconditionally chomping it
would result in a warning.

Signed-off-by: Jakub Narebski <redacted>
Signed-off-by: Junio C Hamano <redacted>
---

diff --git a/gitweb.perl b/gitweb.perl
index 8d15337..aea8856 100755
--- a/gitweb.perl
+++ b/gitweb.perl
@@ -3732,7 +3732,8 @@ sub git_commitdiff {
 			$hash_parent, $hash, "--"
 			or die_error(undef, "Open git-diff-tree failed");
 
-		while (chomp(my $line = <$fd>)) {
+		while (my $line = <$fd>) {
+			chomp $line;
 			# empty line ends raw part of diff-tree output
 			last unless $line;
 			push @difftree, $line;