From: Jason Yundt Date: Tue, 8 Mar 2022 15:56:12 +0000 (-0500) Subject: gitweb: remove invalid http-equiv="content-type" X-Git-Url: https://git.ladys.computer/Gitweb/commitdiff_plain/d73e7f57c959e8c058edc2671fae5ff07ddb11457554afe6bf82b7409d35712a?hp=d5ca249cbe6db5b1ebe794cb3007f2989e36bd62bfad51bf7c2a6482a48ca159 gitweb: remove invalid http-equiv="content-type" Before this change, gitweb would generate pages which included: When a meta's http-equiv equals "content-type", the http-equiv is said to be in the "Encoding declaration state". According to the HTML Standard, The Encoding declaration state may be used in HTML documents, but elements with an http-equiv attribute in that state must not be used in XML documents. Source: This change removes that meta element since gitweb always generates XML documents. Signed-off-by: Jason Yundt Signed-off-by: Junio C Hamano --- diff --git a/gitweb.perl b/gitweb.perl index 8cfa7b8..ce2c48f 100755 --- a/gitweb.perl +++ b/gitweb.perl @@ -4214,8 +4214,7 @@ sub git_header_html { my %opts = @_; my $title = get_page_title(); - my $content_type = get_content_type_html(); - print $cgi->header(-type=>$content_type, -charset => 'utf-8', + print $cgi->header(-type=>get_content_type_html(), -charset => 'utf-8', -status=> $status, -expires => $expires) unless ($opts{'-no_http_header'}); my $mod_perl_version = $ENV{'MOD_PERL'} ? " $ENV{'MOD_PERL'}" : ''; @@ -4226,7 +4225,6 @@ sub git_header_html { - $title