]> Lady’s Gitweb - Gitweb/commitdiff
gitweb: Always use three argument form of open
authorJakub Narebski <redacted>
Sun, 10 May 2009 00:38:34 +0000 (02:38 +0200)
committerLady <redacted>
Mon, 6 Apr 2026 04:50:38 +0000 (00:50 -0400)
In most cases (except insert_file() subroutine) we used old two argument
form of 'open' to open files for reading.  This can cause subtle bugs when
$projectroot or $projects_list file starts with mode characters ('>', '<',
'+<', '|', etc.) or with leading whitespace; and also when $projects_list
file or $mimetypes_file or ctags files end with trailing whitespace or '|'.

Additionally it is also more clear to explicitly state that we open those
files for reading.

Signed-off-by: Jakub Narebski <redacted>
Signed-off-by: Junio C Hamano <redacted>

No differences found
This page took 0.183645 seconds and 4 git commands to generate.