]> Lady’s Gitweb - Gitweb/commitdiff
gitweb: use href() when generating URLs in OPML
authorGiuseppe Bilotta <redacted>
Fri, 2 Jan 2009 12:15:28 +0000 (13:15 +0100)
committerLady <redacted>
Mon, 6 Apr 2026 04:50:38 +0000 (00:50 -0400)
Since the OPML project list view was hand-coding the RSS and HTML URLs,
it didn't respect global options such as use_pathinfo. Make it use
href() to ensure consistency with the rest of the gitweb setup.

Signed-off-by: Giuseppe Bilotta <redacted>
Acked-by: Jakub Narebski <redacted>
Signed-off-by: Junio C Hamano <redacted>
gitweb.perl

index 41f3af74faf7c303ab11455eb4b34ff357d34ccd54c9a72f1b06fb175e5c07d0..96f4e9c630b535da9f174341faa41b8284c80798102124895a8348681350f67b 100755 (executable)
@@ -6247,8 +6247,8 @@ XML
                }
 
                my $path = esc_html(chop_str($proj{'path'}, 25, 5));
-               my $rss  = "$my_url?p=$proj{'path'};a=rss";
-               my $html = "$my_url?p=$proj{'path'};a=summary";
+               my $rss  = href('project' => $proj{'path'}, 'action' => 'rss', -full => 1);
+               my $html = href('project' => $proj{'path'}, 'action' => 'summary', -full => 1);
                print "<outline type=\"rss\" text=\"$path\" title=\"$path\" xmlUrl=\"$rss\" htmlUrl=\"$html\"/>\n";
        }
        print <<XML;
This page took 0.240699 seconds and 4 git commands to generate.