gitweb: Faster return from git_get_preceding_references if possible

Return on first ref found when git_get_preceding_references
is called in scalar context

Signed-off-by: Jakub Narebski <redacted>
Signed-off-by: Junio C Hamano <redacted>

diff --git a/gitweb.perl b/gitweb.perl
index d227f81d3818a82b08bb2a80310261c8416f4f0e679217d265a1169c65a7e740..86cc917593bb171bbc3676816045820879bf3bc99673c6ba3b17f09b9b8c7606 100755 (executable)
--- a/gitweb.perl
+++ b/gitweb.perl
@@ -789,16 +789,15 @@ sub git_get_preceding_references {
                or return undef;
 
        my @reflist;
                or return undef;
 
        my @reflist;

-       my $firstref;

 
        foreach my $commit (@commits) {
                foreach my $ref (@{$refs->{$commit}}) {
 
        foreach my $commit (@commits) {
                foreach my $ref (@{$refs->{$commit}}) {

-                       $firstref = $ref unless $firstref;
+                       return $ref unless wantarray;

                        push @reflist, $ref;
                }
        }
 
                        push @reflist, $ref;
                }
        }
 

-       return wantarray ? @reflist : $firstref;
+       return @reflist;

 }
 
 ## ----------------------------------------------------------------------
 }
 
 ## ----------------------------------------------------------------------