gitweb: Unify the way long timestamp is displayed

format_timestamp_html loses its "-localtime => 1" option, and now
always print the local time (in author/comitter/tagger local
timezone), with "atnight" warning if needed.

This means that both 'summary' and 'log' views now display localtime.
In the case of 'log' view this can be thought as an improvement, as
now one can easily see which commits in a series are made "atnight"
and should be examined closer.

Signed-off-by: Jakub Narebski <redacted>
Signed-off-by: Junio C Hamano <redacted>

diff --git a/gitweb.perl b/gitweb.perl
index 1846968078b8ece285008000a8195796f27c63427610599af5a5f9ab0d5d098c..ca3d1a95c570b1a381a6c65e246da9d5e94156c40fc471771d8e422c80c3986f 100755 (executable)
--- a/gitweb.perl
+++ b/gitweb.perl
@@ -4093,11 +4093,9 @@ sub git_print_section {
 }
 
 sub format_timestamp_html {
-       my ($date, %opts) = @_;
+       my $date = shift;
        my $strtime = $date->{'rfc2822'};
 
-       return $strtime unless $opts{'-localtime'};
-
        my $localtime_format = '(%02d:%02d %s)';
        if ($date->{'hour_local'} < 6) {
                $localtime_format = '(<span class="atnight">%02d:%02d</span> %s)';
@@ -4119,7 +4117,7 @@ sub git_print_authorship {
        my %ad = parse_date($co->{'author_epoch'}, $co->{'author_tz'});
        print "<$tag class=\"author_date\">" .
              format_search_author($author, "author", esc_html($author)) .
-             " [".format_timestamp_html(\%ad, %opts)."]".
+             " [".format_timestamp_html(\%ad)."]".
              git_get_avatar($co->{'author_email'}, -pad_before => 1) .
              "</$tag>\n";
 }
@@ -4146,7 +4144,7 @@ sub git_print_authorship_rows {
                      "</td></tr>\n" .
                      "<tr>" .
                      "<td></td><td>" .
-                     format_timestamp_html(\%wd, -localtime=>1) .
+                     format_timestamp_html(\%wd) .
                      "</td>" .
                      "</tr>\n";
        }