]> Lady’s Gitweb - Gitweb/commitdiff
gitweb: Use rev-list --skip option.
authorRobert Fitzsimons <redacted>
Sun, 24 Dec 2006 14:31:49 +0000 (14:31 +0000)
committerLady <redacted>
Mon, 6 Apr 2026 04:07:11 +0000 (00:07 -0400)
Signed-off-by: Robert Fitzsimons <redacted>
Signed-off-by: Junio C Hamano <redacted>
gitweb.perl

index 22df05dcb018f5bff2c97729f2a0aa8c95fc09b93b4d6ae8ccc9fb43ef57016f..12b27eaf330d2e2242312308a30fdae797248864c7f6d2869a7d247fdfaafce4 100755 (executable)
@@ -1392,35 +1392,13 @@ sub parse_commits {
        $maxcount ||= 1;
        $skip ||= 0;
 
-       # Delete once rev-list supports the --skip option
-       if ($skip > 0) {
-               open my $fd, "-|", git_cmd(), "rev-list",
-                       ($arg ? ($arg) : ()),
-                       ("--max-count=" . ($maxcount + $skip)),
-                       $commit_id,
-                       "--",
-                       ($filename ? ($filename) : ())
-                       or die_error(undef, "Open git-rev-list failed");
-               while (my $line = <$fd>) {
-                       if ($skip-- <= 0) {
-                               chomp $line;
-                               my %co = parse_commit($line);
-                               push @cos, \%co;
-                       }
-               }
-               close $fd;
-
-               return wantarray ? @cos : \@cos;
-       }
-
        local $/ = "\0";
 
        open my $fd, "-|", git_cmd(), "rev-list",
                "--header",
                ($arg ? ($arg) : ()),
                ("--max-count=" . $maxcount),
-               # Add once rev-list supports the --skip option
-               # ("--skip=" . $skip),
+               ("--skip=" . $skip),
                $commit_id,
                "--",
                ($filename ? ($filename) : ())
This page took 0.217344 seconds and 4 git commands to generate.