]> Lady’s Gitweb - Gitweb/commitdiff
gitweb: Silence 'Variable VAR may be unavailable' warnings
authorJakub Narebski <redacted>
Fri, 30 Apr 2010 16:30:31 +0000 (18:30 +0200)
committerLady <redacted>
Mon, 6 Apr 2026 04:50:39 +0000 (00:50 -0400)
When $projects_list points to a directory, and git_get_projects_list
scans this directory for repositories, there can be generated the
following warnings (for persistent services like mod_perl or plackup):

  Variable "$project_maxdepth" may be unavailable at gitweb.cgi line 2443.
  Variable "$projectroot" may be unavailable at gitweb.cgi line 2451.

Those are false positives; silence those warnings by explicitely
declaring $project_maxdepth and $projectroot with 'our', as global
variables, in anonymous subrotine passed to File::Find::find.

Signed-off-by: Jakub Narebski <redacted>
Signed-off-by: Junio C Hamano <redacted>
gitweb.perl

index 1d675614b5b6ecfe5df0d5bd3201b1b2fcf4571eeb9d2e61c430605a2b19b6b7..7d325ae984d91145b856e2daa2963dffcd4b9912d0899f9de9eba0cfc4704526 100755 (executable)
@@ -2442,6 +2442,9 @@ sub git_get_projects_list {
                        follow_skip => 2, # ignore duplicates
                        dangling_symlinks => 0, # ignore dangling symlinks, silently
                        wanted => sub {
+                               # global variables
+                               our $project_maxdepth;
+                               our $projectroot;
                                # skip project-list toplevel, if we get it.
                                return if (m!^[/.]$!);
                                # only directories can be git repositories
This page took 0.194462 seconds and 4 git commands to generate.