gitweb: fix esc_url

Earlier, 452e225 (gitweb: fix esc_param, 2009-10-13) fixed CGI escaping
rules used in esc_url.  A very similar logic exists in esc_param and needs
to be fixed the same way.

Signed-off-by: Pavan Kumar Sunkara <redacted>
Signed-off-by: Junio C Hamano <redacted>

diff --git a/gitweb.perl b/gitweb.perl
index e533708f4224be48b0c5c49b5316e8de6ce90ecb4f027fcd0bf22ee9ce0552d6..2c383545916dc0fc7de27eb91301f6c56dad290c4b6c1c0e109243d583ae521f 100755 (executable)
--- a/gitweb.perl
+++ b/gitweb.perl
@@ -1328,8 +1328,7 @@ sub esc_param {
 sub esc_url {
        my $str = shift;
        return undef unless defined $str;
 sub esc_url {
        my $str = shift;
        return undef unless defined $str;

-       $str =~ s/([^A-Za-z0-9\-_.~();\/;?:@&=])/sprintf("%%%02X", ord($1))/eg;
-       $str =~ s/\+/%2B/g;
+       $str =~ s/([^A-Za-z0-9\-_.~();\/;?:@&= ]+)/CGI::escape($1)/eg;

        $str =~ s/ /\+/g;
        return $str;
 }
        $str =~ s/ /\+/g;
        return $str;
 }