If one of $site_header, $site_footer or $home_text is not defined, you
get extraneous errors in the web logs, for example (line wrapped for
better readibility):
[Wed Jan 13 16:55:42 2010] [error] [client ::1] [Wed Jan 13 16:55:42 2010]
gitweb.cgi: Use of uninitialized value $site_header in -f at
/var/www/gitweb/gitweb.cgi line 3287., referer: http://git/gitweb.cgi
This ensures that those variables are defined before trying to use it.
Note that such error can happen only because of an error in gitweb
config file; building gitweb.cgi can make mentioned variables holding
empty string (it is even the default), but they are still defined.
Signed-off-by: John 'Warthog9' Hawley <redacted>
Signed-off-by: Jakub Narebski <redacted>
Signed-off-by: Junio C Hamano <redacted>
print "</head>\n" .
"<body>\n";
print "</head>\n" .
"<body>\n";
+ if (defined $site_header && -f $site_header) {
insert_file($site_header);
}
insert_file($site_header);
}
print "</div>\n"; # class="page_footer"
}
print "</div>\n"; # class="page_footer"
}
+ if (defined $site_footer && -f $site_footer) {
insert_file($site_footer);
}
insert_file($site_footer);
}
+ if (defined $home_text && -f $home_text) {
print "<div class=\"index_include\">\n";
insert_file($home_text);
print "</div>\n";
print "<div class=\"index_include\">\n";
insert_file($home_text);
print "</div>\n";
Lady’s Gitweb / Gitweb / commitdiff